Fix #7354 - Implementing NSE in cube#7569
Closed
sisyphuswastaken wants to merge 28 commits intoRdatatable:masterfrom
Closed
Fix #7354 - Implementing NSE in cube#7569sisyphuswastaken wants to merge 28 commits intoRdatatable:masterfrom
sisyphuswastaken wants to merge 28 commits intoRdatatable:masterfrom
Conversation
This reverts commit 2b7b7ff.
sisyphuswastaken
requested review from
MichaelChirico and
jangorecki
as code owners
sisyphuswastaken
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7569 +/- ##
==========================================
- Coverage 99.00% 98.91% -0.09%
==========================================
Files 87 87
Lines 16893 16800 -93
==========================================
- Hits 16725 16618 -107
- Misses 168 182 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sisyphuswastaken
requested review from
HughParsonage,
aitap,
ben-schwen and
tdhock
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR continues work from #7543
I have worked towards encapsulating the SDcols processing logic into a helper function, .processSDcols. In accordance with the previous review, the function has been moved to data.table.R.
I am still working on removing the try-catch block and replacing it with errors for easier debugging.